Jump to content

ruubi

Community
 View Profile  See their activity

  • Content Count

    94

  • Joined

  • Last visited

  • Days Won

    15

Posts posted by ruubi

  1. Posted · Edited by ruubi · Report reply

    Hello, before leaving ToP community for good, I want to release a list made by me and a friend, I hope this helps everyone, and I wish people can contribute and help each other with fixes for these bugs.
    (Note: There might be bugs that don't happen in your client, we mentioned it there from other's experiences)
     

    List by yagura2k(me) & Mothanna

    AccountServer:
        * Sql-Injection. --mac change packet
        * Sending a big packet len -> a possible way of crash. --Change header of username login to 20k leads to crash
        
    GameServer:
        * Case 2(CCharacter::ProcessPacket) -> can run lua cmds through here and have control over all the host aswell(remove it, it is a backdoor)
        * Offline-Stall Crash. --This one has multi reasons, what we are talking her about memaddre co set it to -1 which is cause of the crash.
        * DoString Crash/lua51. -No info about this, it was nostring from debugger.
        * Gold-hack. --When you have locked states by lock inventory or locked by trade/stall and send sell packet to npc.
        * AfterEnterMap/BeforeLeaveMap Crash. --No info about this happened once
        * Long Item-string Crash. --Takeitem Additem if itemname > 32 len its overflow buffer and crash GameServer.
        * Item-click bug(You cannot consume or double-click items, you can but it's really hard to).
              -It's from the rightclick addon in gameserver made by co for new pet system, just remove it.
        * Switch Item with F1-F12 Bar -> If this gets spammed, it can crash the person who is standing besides you.
             -This not common happen only if u have 1 ping just keep switch weapon will crash all people around you
        * Guild-bank -> Moving items and spamming them, can lead to a GameServer crash, has to be checked. --Dupe while using boats, just check on it, and packet query size is 10.
        * MoveCity Crash. --Happens when have invalid birthcity.
        * Bag of Holding -> Has to be removed unless the code is re-written, it is broken.
        * Accept guild notice wrong message.
        * Mentoring while offline-stalling -> can lead to GameServer crash.
        
    GateServer:
        * 03 Packet Crash. --Packet editor header its inside sdk server file packet len 66k
        * Disconnect by spamming loot.
        * Register Feature -> It is not safe to use unless there's captcha or cooldown for creating accounts.
        * ToProcess:OnClient Packet len crash. --WPE 6 len key has no check if its <6 so if its <6 gate crash.
        
    GroupServer:
        * Create Pin-Code Sql-Injection. --This one is a clear known bug.
        * Pin Code Sql-Injection. -This one is a clear known bug.
        * Bag of Holding -> Has to be removed unless the code is re-written, it is broken.
        
    Lua:
        * Analyze-dupe -> can be fixed by adding a check for locked item in analyze system.
        * Stalling locked item -> can be fixed by adding a check for locked items as well.
        * Lua51 has to be upgraded. --LUAJIT to 2.0.5.
        * MapUtil bug, can lead to a GameServer Freeze. --This is a theory.
        * Overall checks for everything for locked items, everything has to have a check if item is locked or not.
        * Star of Unity Formula & Rewards -> Urgent, has to be re-written and checked before launching the server.
        * Newbie Box Rewards -> Urgent as well, the rewards for every class has to be checked!(Encountered before, lv50 staff from lv25 newbie chest).
        * Experience system -> Has to be checked as well! Experience will most likely get bugged after level 35-45. --EXP system has exp jump on lv 79 to 91
        * Spawn points -> Has to be checked for teleporters. -same as MoveCity issue, if has invalid birth, its gonna crash.
        
        
        
    Client:
        * Block system is not working, you block someone then if you relog, the block list gets wiped.
        * Using Guild-Colors/Forms -> not safe, this has been tested and you can crash everyone's client that sees your character.
        * Screenshot client crash. --Buffer overflow for 4k.
        * Trade-value wrong when buying something from NPC.
        * Client will crash while you use manu's. --When you have x1 manu left in your inventory and use it, it will crash your client.
        * Using some skills will make the character freeze & stuck or can be stunned forever as well.
        * MPTerrain Destructor Crash -> usually happens in PK with a good more or less amount of people(It can crash during randomly walking or teleporting as well).
        * Buffing someone or yourself -> leading for the character to die. --This happens due timer when timer becomes 1 or less and u use skill on that person it kill it, the fixed been pushed in top-recode.
        * Colour Notice Crash. --Happens due to visual studio upgrade.
        * Using guild-bank and spamming it can lead to a client crash.  --Happens due syn, a guild bank cool-down would work as a workaround fix.


    Note 2: There might be more than these! if you know more, share it in this topic so other's know about it!
    Thank you ToP for all these years!
        

    • Thanks 1

  2. Posted · Report reply

    8 hours ago, deguix said:

    I keep getting "Wrong game version" with these files, even though I put Version=136 in GateServer.cfg's "[Main]" and client sources have that as 136. Any idea on how to fix that?

    Check the WPE key in NetIF.cpp, and check if it's the same as the one in GateServer.cfg, if it's not, match them and you shouldn't get version mismatch anymore.
    E.g:
    GateServer.cfg = WpeVersion = 0x8D1C
    NetIF.cpp / void NetIF::SendPacketMessage(LPWPACKET pk) = pk.WriteShort(0x8D1C);

  3. Posted · Edited by ruubi · Report reply

    1 hour ago, squaller said:

    client deleted

    Seems like the game client link has expired yeah, if any of you got clean corsairs client and got a link for it let me know and I'll update the Readme.md

    • Like 1

  16. Posted · Edited by yagura2k · Report reply

    Hello there!
    I am searching for 3-5 developers that have the knowledge of the following things:

     

    -LUA (Angelix, another one will be gladly welcomed)

    -C/C++(I am working with the server/client sources, however another c/c++ developer would be useful)

    -Graphic designer(knowledge of making custom apparels/maps/logos/etc..)

     

    Things will be very organized, everyone will have their own tasks.

     

    I am building a team in order to create a PK long-term server, if you are interested you can contact me through discord: yagura2k#2968

    • Like 4

  18. Posted · Report reply

    On 7/27/2020 at 9:32 AM, mcjc said:

    Hello friends, how are you ?
    sorry to revive the topido.
    I'm here with our dear server haha
    how do I return this issue of slot to the default and also leave the fusi of the default app like this server?
    or I have to edit something in the exe, sorry I'm a layman with that.
    Do I not only say the question of the skill but the functionality of the inventory to the standard being able to leave 110%? can something explain to me how can i do this

    image.png.0cbe868c011cbf8d0a0d31cfde2e9952.png

     

    not only in the standard skill scheme but also in the standard inventory functionality.
    can someone help me with this or give me a hint of what i should do?

     

    image.png.749556c00d89c503a7b9c4f8128afc91.png

    To be able to switch back to the normal inventory system, you will have to do edits on both sources(server/client/forms), doing this is pretty tough, but with some practice you will be able to do it. You just need a bit of experience in searching for X thing in the sources, having this knowledge will be very helpful for you.

  19. Posted · Report reply

    4 minutes ago, johan said:

    The error has been corrected, I mention it because the other solutions are complete and yours is incomplete.
    Solution for future readers: Apply the settings proposed by @yagura2k and @Fritt, and take care to check if the variable
    "#define CMD_CM_GAME_REQUEST_PIN CMD_CM_BASE + 101" is found in the document NetCommand.h on line 159.
     

    On the other hand, thank you for sharing a bit of your work and allowing new developers to work on this project.

     

    No worries, looking forward to see more developers

    • Like 1

  20. Posted · Report reply

    On 7/12/2020 at 3:13 AM, johan said:

    when compiling these errors arise:

     

    Game error LNK2019: unresolved external symbol "void __cdecl CS_SendGameRequest(char const * const)" (?CS_SendGameRequest@@YAXQBD@Z) referenced in function "protected: void __thiscall GUI::CDoublePwdMgr::SendGameRequest(void)" (?SendGameRequest@CDoublePwdMgr@GUI@@IAEXXZ)
     

    Game fatal error LNK1120: 1 unresolved externals
     

    Try to find out what's wrong, that's how you learn

×
×
  • Create New...