Fritt

@TaTaFernada Give us more info about how you getting crash, how to replicate that?

Bug Title: Guild Exp and Stats Bug Description: Guild exp and states on disband function do not reset in GroupServer How to replicate: Guild exp and States on disband function do not reset in groupserver , which is when create new guild will take old points of the disbanded guild Status: OPEN Author (whoever that fixes it):

Bug Title: Hair NPC / Exchanger NPC Crash Client Bug Description: Hair NPC / Exchanger NPC Crashes the client when hovering items How to replicate: Check Hair NPC and click around it and your client will crash, if you allow Exchanger NPC to hover items it will crash your client when you view those items! Status: CLOSED Author: Fritt Open UIGuiData.cpp and search for: Replace it with:

Bug Title: Switch item flood crashes all people clients on the range Bug Description: Switching Items can flood and will crashes all people clients on the range How to replicate: Stay near some players and Switch items using F-Skills for fast switches Status: OPEN Author (whoever that fixes it):

Bug Title: Item Price on Invertory Bug Description: Item Price on inventory is not divided by 2 which means it shows same Trade Value as you see at NPC How to replicate: Visit any npc and buy any item, the Trade Value of that item will be same even after you purchase it! Status: OPEN Author (whoever that fixes it):

Bug Title: Hair NPC / Exchanger NPC Crash Client Bug Description: Hair NPC / Exchanger NPC Crashes the client when hovering items How to replicate: Check Hair NPC and click around it and your client will crash, if you allow Exchanger NPC to hover items it will crash your client when you view those items! Status: OPEN Author (whoever that fixes it):

Bug Title: Guild Crashes Client Bug Description: Creating Guild Crashes Client or by Disband & Create How to replicate: Go to npc on icicle and try create a guild, once its done your client will crash, it even crashes when you disband an old guild and create a new one! Status: OPEN Author (whoever that fixes it):

Lets keep this thread clean only for inside bugs. @KONG i can test those but idk how to make a repo, tho i think sharing fixes here on this way we all can see the fixed code when we replace and know how it works, if each developer contributes with atleast 1 fix we can have it fixed, so lets see if anyone will.

Bug Title: Level Requirement on Trade Window Bug Description: Missing Level Requirement until you purchase the item How to replicate: Visit any NPC that Sells Items and Hover your mouse into the item Status (pending / close / open): CLOSED Author (whoever that fixes it): Fritt Client Source - UIItemCommand.cpp Find: PUSH_HINT( g_oLangRec.GetString(628), _ItemData.sNeedLv, pAttr->get(ATTR_LV)>=_ItemData.sNeedLv ? GENERIC_COLOR : VALID_COLOR ); and replace with: sprintf( buf, g_oLangRec.GetString(628), _pItem->sNeedLv, pAttr->get(ATTR_LV)>=_pItem->sNeedLv ? GENERIC_COLOR : VALID_COLOR ); PushHint( buf, GENERIC_COLOR );

Clean list of the Server improvements so you can directly go to the comment that you're interested in. Server-Side Improvements:

Clean list of the game improvements so you can directly go to the comment that you're interested in. Game Improvements:

Clean list of the architecture improvements so you can directly go to the comment that you're interested in. Architecture Improvements:

Clean list of the bug reports so you can directly go to the comment that you're interested in. Bug Reports and Status: Level Requirement on Trade Window / CLOSED Guild Crashes Client / OPEN Hair NPC / Exchanger NPC Crash Client / CLOSED Item Price on Invertory / CLOSED Guild Exp and Stats / OPEN Switch Item Flood Crashes all people Clients on the range / OPEN Character Disappears when relogged / CLOSED Bank PIN Value / CLOSED Ship Upgrade / CLOSED Flood buttons/exp/guild color/ addexpguild / OPEN Pet Skills / CLOSED Discord or Vip - there is no nickname in the message / CLOSED Movement Bug / OPEN

Copying this Thread of @Angelix so we can Fix both Server / Client Source together ( CO Src ) Hello community of pkoDev, some time ago we got our hands on the source code for the game we love and have been creating unique stuff for years. Many (including myself) are completely useless when trying to build and make a functional application out of the Chinese sources so not many people were using them. Now, thanks to the Sheep Squad (KONG, Billy, Wrexor, Mii, Foxseiz & Snre3n), they have released the source code for the server-side applications and a client. We have to thank them for it, since this improves the community as a whole and now you start seeing a few servers popping up. While they're functional, there have been comments about them having some minor issues, which we as a community can come together to fix as a public source code. This thread is created thanks to KONG for giving the idea and is not to bring any other issue/dramas that showed up in the other thread. This thread's only purpose is to identify issues/improvements and share the code that can fix and/or improve the code, therefore: Anyone is allowed to post anything they might have found, even if they don't have an immediate fix for it. Anyone is allowed to contribute fixes to other people's issues and their own. Anyone is allowed to contribute improvements to existing code. If any issue fix and/or improvement is shared and you can make the code better, feel free to contribute! Note1: This thread is not about fixing the directories, missing files or compiling source code itself, that's explained on the original release thread. Note2: This is my first time doing a thread like this, so if I'm missing anything to add, let me know! So for as posting something, lets follow the example stated by KONG. For Bug Reports, follow this: Bug Title: Bug Description: How to replicate: Status (pending / close / open): Author (whoever that fixes it): For Architecture Improvements, follow: Title: Refactor to MVC design pattern Reason: scalability and maintainability Approach: For Game (Client-Side) Improvements, follow this: Title: Reason: Improve existing guild functions Approach: SQL table, Open-closed, etc Concerns: concurrency, race, etc For Server (Server-Side) Improvements, follow this: Title: Reason: Improve existing guild functions Approach: SQL table, Open-closed, etc Concerns: concurrency, race, etc Please try posting the actual fixes, if you can, try explaining what was done so the rest of people reading the thread can learn if they're interested. Avoid just posting the whole file like "here's the fixes inside my functions.lua" and posting your 20K line file, try posting just the fixes/changes.

Hi everyone, can someone tell me where i can find Item Level on source? ex: While on BUY Page, it won't show the item level, but when i purchase it, it shows at invertory. Where i can look for this function? i found something but it wasn't related to this Thanks alot.

Hello guys, I’m trying to get CO src Server / Client to work together but im having some issues that im unable to log into a new account. Has anyone managed to make them work?

Anyone managed to have these commons working?

Can you give me an example of that? Idk where to start

I’m using same OS and its working fine o.o The problem is you won’t be able to login ur account bcz common mismatches the server src. Could you share ur common files? If this are the same as you say should’ve worked fine

Can someone share Common Folder that matches the Public Server Src?

Can you share Client folder on VS 2003 aswell? Unable to compile it this way..

This is a thread requesting to bo shared not to buy o.o

Hmm.. could you share it? Would give it a try

I’m making this thread to request CO Client Src, maybe you share client src? I don’t see anyone working while nobody has client src, maybe sharing it would grab more attention so we can work and see the top development going further? It’s been along time since you guys shared server-side i think it would be good sharing client src, @KONG @Wrexor

Can you share client src? I don’t see anyone working while nobody has client src, maybe sharing it would grab more attention so we can work and see the top development going further? It’s been along time since you shared server-side i think it would be good sharing client src, @KONG @Wrexor