CheckMonsterDead

[FapFap 13]

I'm having a error at lua_err spamming almost all the time when dw gets on, im using a dw boss checker if dw boss 1 is dead then you be able to go to dw 2 and im having this error at lua_err (but script works fine) it's just this error that keeps spamming:

lua_err.txt:


Function.lua:

[iZae 55]

replace 2310 line to:

if Hp(role)<=0 or Hp(role)==nil then

 

 

[FapFap 13]

5 hours ago, iZae said:

replace 2310 line to:

if Hp(role)<=0 or Hp(role)==nil then

 

 

still the same error on same line

[MonkeyCode 453]

write test unit with pcall and "assert"

[V3ct0r 2,117]

Check that role is a valid descriptor of monster. Show your script where you use the CheckMonsterDead function.

[FapFap 13]

12 hours ago, V3ct0r said:

Check that role is a valid descriptor of monster. Show your script where you use the CheckMonsterDead function.

I use the script on ctrl.lua at map files to make a check for dw boss, the script works fine but i only getting those errors spamming lua_err.txt

[FapFap 13]

14 hours ago, Stinger said:

Use this:

function CheckMonsterDead(role)
  
  if (Hp(role) == nil or Hp(role) <= 0) then -- First of all, always check nil.
    	return 1
  end
  
end

 

 

should i replace my whole function to urs?

[Inuarashi 5]

2 hours ago, FapFap said:

should i replace my whole function to urs?

 

the problem error is that, sometimes it happens that the value hp(role) is nil , and there is nothing to handle that, so the error comes up

 

a way to fix it is to add something to handle that situation. such as the code above.

 

if the value is nil, or the value is less than 0 , do someting, end.

 

Edited August 26, 2018 by Inuarashi

[MonkeyCode 453]

the function is not bugged (everyone is using it). You just need to pass in a role.
And because you check if the monster is dead inside map_run, it runs every second even if sometimes your variable DWboss1 is "null".

Better you go do your actions at GetExp_New / GetExp_PKM,
if dead == DWboss1 then
  DWport1 = 1
end

and inside map_close:
DWboss1 = nil -- note the nil here (one reason why you could be getting the errors

[FapFap 13]

i should add this at getexp_new or getexp_pkm?

1 hour ago, KONG said:

Better you go do your actions at GetExp_New / GetExp_PKM,
if dead == DWboss1 then
  DWport1 = 1
end
 

or maybe both